Skip to content

Sync rustc_codegen_cranelift#78624

Merged
bors merged 26 commits into
rust-lang:masterfrom
bjorn3:update_cg_clif-2020-11-01
Nov 3, 2020
Merged

Sync rustc_codegen_cranelift#78624
bors merged 26 commits into
rust-lang:masterfrom
bjorn3:update_cg_clif-2020-11-01

Conversation

@bjorn3

@bjorn3 bjorn3 commented Nov 1, 2020

Copy link
Copy Markdown
Member

This fixes bootstrapping of rustc using cg_clif again. It regressed a while before #77975 got merged.

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/743

bjorn3 and others added 11 commits October 27, 2020 10:59
Fixes compilation without -Ztrim-diagnostic-paths=no
Per their documentation, the `max_value()` and `min_value()` associated functions have been superseded by the `MAX` and `MIN` associated constants since Rust 1.43 and are considered "soft deprecated", with all uses currently being replaced in the rustc repo.
Prefer numeric associated constants in example
Fixes bootstrapping of rustc using cg_clif

Fixes rust-lang#1097
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2020
@bjorn3

bjorn3 commented Nov 1, 2020

Copy link
Copy Markdown
Member Author

I wrote a post about my debugging process to fix bootstrapping using cg_clif: https://bjorn3.github.io/2020/11/01/fixing-rustc-bootstrap-with-cg_clif.html

@jyn514 jyn514 added A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2020
@bjorn3 bjorn3 force-pushed the update_cg_clif-2020-11-01 branch from d7192c8 to 216c4ae Compare November 3, 2020 10:01
@jyn514

jyn514 commented Nov 3, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 216c4ae has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 3, 2020
…=jyn514

Sync rustc_codegen_cranelift

This fixes bootstrapping of rustc using cg_clif again. It regressed a while before rust-lang#77975 got merged.

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/743
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#77950 (Add support for SHA256 source file hashing)
 - rust-lang#78624 (Sync rustc_codegen_cranelift)
 - rust-lang#78626 (Improve errors about #[deprecated] attribute)
 - rust-lang#78659 (Corrected suggestion for generic parameters in `function_item_references` lint)
 - rust-lang#78687 (Suggest library/std when running all stage 0 tests)
 - rust-lang#78699 (Show more error information in lldb_batchmode)
 - rust-lang#78709 (Fix panic in bootstrap for non-workspace path dependencies.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 39f5563 into rust-lang:master Nov 3, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 3, 2020
@bjorn3 bjorn3 deleted the update_cg_clif-2020-11-01 branch November 3, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile rustc using cg_clif

8 participants